janhoy commented on PR #4604: URL: https://github.com/apache/solr/pull/4604#issuecomment-4875332160
There were hundreds of warnings for the new / stronger errorprone rules. Claude found most of the invocations to be legit, such as `==` for comparing objects instead of `.equals()` since we look for same-instance proof. For other things like `Charset.forName()` there are real code changes. It could be argued that we handle both "warn" and "error" in the same PR. But also "warn" recommendations are worth fixing. But what benefit does splitting into two PRs give us further down the road? @epugh Any particular reason you expected more real code change as a result of the new rules? I's not that we haven't been fixing errorprone feeback earlier and have a backlog. This is only reacting to the new/tighter rules in this partifular version bump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
