dsmiley commented on code in PR #4604: URL: https://github.com/apache/solr/pull/4604#discussion_r3521601682
########## changelog/unreleased/PR#4604-update-google-errorprone.yml: ########## @@ -0,0 +1,8 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: Update com.google.errorprone to 2.50.0 and fix/suppress new bug patterns (ReferenceEquality, JdkObsolete, NotJavadoc, TypeParameterQualifier) +type: dependency_update Review Comment: IMO "dependency_update" usage should be restricted to dependencies shipped with a binary Solr distribution. If it's broader than that; it's uninteresting / less useful and takes more human judgement to gauge... "do I care about this" (as a user). I appreciate you are making these static analysis improvements. Weather they are found by Sonar, IntelliJ, Errorprone, or you woke up one day and had to scratch that itch without any tool saying so -- who cares. The changes themselves is the substance that may or may not be changelog worthy. That a dependency we do not include with Solr got bumped and found them isn't relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
