epugh commented on PR #4604: URL: https://github.com/apache/solr/pull/4604#issuecomment-4875400516
> @epugh Any particular reason you expected more real code change as a result of the new rules? I's not that we haven't been fixing errorprone feeback earlier and have a backlog. This is only reacting to the new/tighter rules in this partifular version bump. I guess I was thinking that there would be more "modern java coding practices should be used" that this would flag by doing a suppression of a warning. I think all of this looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
