dsmiley commented on code in PR #4612:
URL: https://github.com/apache/solr/pull/4612#discussion_r3536638940
##########
solr/core/build.gradle:
##########
@@ -83,31 +80,25 @@ dependencies {
implementation libs.apache.lucene.sandbox
implementation libs.apache.lucene.spatialextras
implementation libs.apache.lucene.suggest
-
// Collections & lang utilities
implementation libs.google.guava
implementation libs.apache.commons.lang3
implementation libs.apache.commons.math3
implementation libs.commonsio.commonsio
implementation libs.carrotsearch.hppc
-
- implementation(libs.benmanes.caffeine) {transitive = false}
+ api(libs.benmanes.caffeine) {transitive = false}
Review Comment:
I'm not surprised that we have a number of dependencies like this that
technically are exposed in our public API. But I have some decades here to
judge that some of our dependencies are conceptually an internal / niche use
and not widespread enough to warrant the "api" transitive implications.
Where I didn't comment, I implicitly concurred with your choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
