NextbrickInc opened a new pull request, #4818: URL: https://github.com/apache/solr/pull/4818
https://issues.apache.org/jira/browse/SOLR-18347 # Description Fixes the first defect listed in SOLR-18347: navigating to a per-collection page can intermittently invoke `showCore()` with a null core while the shared menu resolves, causing `TypeError: Cannot read properties of null (reading 'name')`. This pull request addresses only that null-core defect, not the other items in the umbrella issue. # Solution Guard the route change in `showCore()` until a core object is present. The existing Selenium console-error exemption for this TypeError is removed so a recurrence is reported as a test failure. This patch was developed with substantial assistance from OpenAI Codex. The resulting two-file diff was reviewed and validated locally. # Tests - `./gradlew tidy` passed. - JavaScript syntax validation passed with the bundled Node.js runtime. - `AdminUiSmokeTest` and `AdminUiParamsetsScreenTest` compiled successfully. - The seven targeted Selenium cases were skipped because Chrome/Chromium was unavailable on the local host. - The broader non-test check progressed through 472 tasks; unrelated worktree RAT handling and a space-in-path Antora failure prevented a complete local run. # Checklist - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (Not available for organization-owned forks.) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. (The existing Selenium assertion now covers the regression after removing its exemption.) - [ ] I have added documentation for the Reference Guide. (Not applicable to this UI bug fix.) - [ ] I have added a changelog entry. (Not added for this narrow fix.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
