janhoy commented on code in PR #4818:
URL: https://github.com/apache/solr/pull/4818#discussion_r3870652254
##########
solr/webapp/web/js/angular/app.js:
##########
@@ -653,7 +653,9 @@ solrAdminApp.controller('MainController', function($scope,
$route, $rootScope, $
}
$scope.showCore = function(core) {
- $location.url("/" + core.name + "/core-overview");
+ if (core) {
+ $location.url("/" + core.name + "/core-overview");
Review Comment:
Is this fixing the "Menu TypeError on per-collection pages" issue?
##########
solr/webapp/web/js/angular/controllers/core-overview.js:
##########
@@ -56,14 +56,16 @@ function($scope, $rootScope, $routeParams, Luke, CoreInfo,
Update, Replication,
$scope.refreshPing = function() {
Ping.status({core: $routeParams.core}, function(data) {
- if (data.error) {
+ if (data.status == "not_configured") {
$scope.healthcheckStatus = false;
- if (data.error.code == 503) {
- $scope.healthcheckMessage = 'Ping request handler is not configured
with a healthcheck file.';
- }
+ $scope.healthcheckMessage = 'Ping request handler is not configured
with a healthcheck file.';
} else {
+ delete $scope.healthcheckMessage;
$scope.healthcheckStatus = data.status == "enabled";
Review Comment:
Will not `data.status == 'disabled'` need a different handling?
##########
solr/webapp/web/js/angular/controllers/schema-designer.js:
##########
@@ -451,9 +455,11 @@ solrAdminApp.controller('SchemaDesignerController',
function ($scope, $timeout,
// re-apply the filters on the updated schema
$scope.onTreeFilterOptionChanged();
- // Load the Luke schema
- Luke.schema({core: data.core}, function (schema) {
- Luke.raw({core: data.core}, function (index) {
+ // Route Luke through the temporary collection so the request reaches its
+ // active replica even when the Admin UI is connected to a different node.
+ var lukeTarget = data.tempCollection || data.core;
Review Comment:
Was this a condition that was uncovered by the selenium test, or something
reported elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
