nick-boss-tech commented on PR #5112: URL: https://github.com/apache/solr/pull/5112#issuecomment-6392310976
**AI Review:** **P2, new:** A GET query such as ?foo=X-Solr-targetNode causes the filter to overwrite a valid targeting header with null. The request then runs on the receiving node instead of the selected node. Preserve the header unless the actual targeting parameter exists. [Code](https://github.com/apache/solr/blob/b4fa46f1ecb11a60cc2cfd4783492639bb4e3a85/solr/core/src/java/org/apache/solr/servlet/NodeTargetProxyFilter.java#L79-L85) **P3:** The guide promises 404 for unknown nodes; the agreed implementation and tests use 400. **Existing concern:** Certificate-based caller identity remains unresolved. The new Basic Auth tests do not close that already-raised issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
