[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427981 ]
ASF GitHub Bot logged work on WW-4789: -------------------------------------- Author: ASF GitHub Bot Created on: 28/Apr/20 05:59 Start Date: 28/Apr/20 05:59 Worklog Time Spent: 10m Work Description: lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416348145 ########## File path: core/src/main/java/org/apache/struts2/ServletActionContext.java ########## @@ -26,23 +26,18 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.jsp.PageContext; -import java.util.Map; /** * Web-specific context information for actions. This class subclasses <tt>ActionContext</tt> which * provides access to things like the action name, value stack, etc. This class adds access to * web objects like servlet parameters, request attributes and things like the HTTP session. */ -public class ServletActionContext extends ActionContext implements StrutsStatics { - - private static final long serialVersionUID = -666854718275106687L; +public class ServletActionContext implements StrutsStatics { public static final String STRUTS_VALUESTACK_KEY = "struts.valueStack"; - public static final String ACTION_MAPPING = "struts.actionMapping"; Review comment: It was just moved into `StrutsStatics` so you can still access it via `ServletActionContext. ACTION_MAPPING` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 427981) Time Spent: 0.5h (was: 20m) > ActionContext should be immutable > --------------------------------- > > Key: WW-4789 > URL: https://issues.apache.org/jira/browse/WW-4789 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Major > Fix For: 2.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Right now ActionContext is a bag of different contexts with mixed > responsibility. Also some of them lay in ThreadLocal variable, but some are > accessed directly. Also it is easily to modify the internal state which > shouldn't be possible. The context should be constant during whole action > execution period. -- This message was sent by Atlassian Jira (v8.3.4#803005)