[ https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=427990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-427990 ]
ASF GitHub Bot logged work on WW-4789: -------------------------------------- Author: ASF GitHub Bot Created on: 28/Apr/20 06:13 Start Date: 28/Apr/20 06:13 Worklog Time Spent: 10m Work Description: lukaszlenart commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r416353490 ########## File path: core/src/main/resources/struts-default.xml ########## @@ -68,7 +68,6 @@ <constant name="struts.excludedPackageNames" value=" ognl., - java.io., Review comment: Yes, it was added [herre](https://github.com/apache/struts/pull/371/files#diff-710b29900cea21e85893cae43dd08c92) but during my tests file upload stop working in the Showcase app. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 427990) Time Spent: 1h 10m (was: 1h) > ActionContext should be immutable > --------------------------------- > > Key: WW-4789 > URL: https://issues.apache.org/jira/browse/WW-4789 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Major > Fix For: 2.6 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Right now ActionContext is a bag of different contexts with mixed > responsibility. Also some of them lay in ThreadLocal variable, but some are > accessed directly. Also it is easily to modify the internal state which > shouldn't be possible. The context should be constant during whole action > execution period. -- This message was sent by Atlassian Jira (v8.3.4#803005)