[
https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=429879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429879
]
ASF GitHub Bot logged work on WW-4789:
--------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/20 21:14
Start Date: 02/May/20 21:14
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on a change in pull
request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r419008690
##########
File path: core/src/main/resources/struts-default.xml
##########
@@ -68,7 +68,6 @@
<constant name="struts.excludedPackageNames"
value="
ognl.,
- java.io.,
Review comment:
Hi @lukaszlenart. A quick check confirms the upload failure is
happening in the Showcase application snapshots (2.6 and 2.5). After digging a
little into the cause, I still think we'd be safer leaving `java.io` in the
default exclusion list.
My proposal is to open a JIRA for the Showcase issue and fix-or-workaround
the upload failure in the Showcase application instead (leaving `java.io` in
the default exclusion list).
How does that sound to you ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 429879)
Time Spent: 1h 40m (was: 1.5h)
> ActionContext should be immutable
> ---------------------------------
>
> Key: WW-4789
> URL: https://issues.apache.org/jira/browse/WW-4789
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 2.6
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Right now ActionContext is a bag of different contexts with mixed
> responsibility. Also some of them lay in ThreadLocal variable, but some are
> accessed directly. Also it is easily to modify the internal state which
> shouldn't be possible. The context should be constant during whole action
> execution period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
