[ 
https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885219
 ]

ASF GitHub Bot logged work on WW-5355:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Oct/23 13:36
            Start Date: 15/Oct/23 13:36
    Worklog Time Spent: 10m 
      Work Description: kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359879865


##########
core/src/main/resources/org/apache/struts2/default.properties:
##########
@@ -243,25 +243,25 @@ struts.ognl.enableExpressionCache=true
 ### For expressionCacheLRUMode true, the limit will ensure the cache does not 
exceed
 ### that size, dropping the oldest (least-recently-used) expressions to add 
new ones.
 ### NOTE: If not set, the default is 25000, which may be excessive.
-# struts.ognl.expressionCacheMaxSize=1000
+struts.ognl.expressionCacheMaxSize=10000

Review Comment:
   I ended up defining the defaults in the properties file and removing 
defaults from the code - except for required values when bootstrapping the 
container. (And except for a deprecated constructor which is awaiting deletion)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 885219)
    Time Spent: 3h  (was: 2h 50m)

> Use LRU cache by default
> ------------------------
>
>                 Key: WW-5355
>                 URL: https://issues.apache.org/jira/browse/WW-5355
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Kusal Kithul-Godage
>            Priority: Minor
>             Fix For: 6.4.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to