[
https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885225
]
ASF GitHub Bot logged work on WW-5355:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/23 13:51
Start Date: 15/Oct/23 13:51
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359882251
##########
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java:
##########
@@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {
enableExpressionCache = BooleanUtils.toBoolean(cache);
}
- @Inject(value = StrutsConstants.STRUTS_OGNL_EXPRESSION_CACHE_MAXSIZE,
required = false)
Review Comment:
Doesn't make much sense to inject this both in the factory and here. Plus,
Caffeine doesn't support changing the max size after construction (and neither
does LRU really), so we'd have to rebuild the cache to continue supporting this
method. I can't see much use for it anyway so I've just gone ahead and
deprecated it.
Issue Time Tracking
-------------------
Worklog Id: (was: 885225)
Time Spent: 4h (was: 3h 50m)
> Use LRU cache by default
> ------------------------
>
> Key: WW-5355
> URL: https://issues.apache.org/jira/browse/WW-5355
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
