[
https://issues.apache.org/jira/browse/WW-5355?focusedWorklogId=885221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885221
]
ASF GitHub Bot logged work on WW-5355:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/23 13:42
Start Date: 15/Oct/23 13:42
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359880961
##########
core/src/main/java/com/opensymphony/xwork2/ognl/DefaultOgnlCacheFactory.java:
##########
@@ -15,52 +15,86 @@
*/
package com.opensymphony.xwork2.ognl;
-import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.concurrent.atomic.AtomicInteger;
import org.apache.commons.lang3.BooleanUtils;
/**
- * Default OGNL Cache factory implementation.
+ * <p>Default OGNL Cache factory implementation.</p>
*
- * Currently used for Expression cache and BeanInfo cache creation.
+ * <p>Currently used for Expression cache and BeanInfo cache creation.</p>
*
- * @param <Key> The type for the cache key entries
+ * @param <Key> The type for the cache key entries
* @param <Value> The type for the cache value entries
*/
public class DefaultOgnlCacheFactory<Key, Value> implements
OgnlCacheFactory<Key, Value> {
- private final AtomicBoolean useLRUCache = new AtomicBoolean(false);
- private final AtomicInteger cacheMaxSize = new AtomicInteger(25000);
Review Comment:
Making this factory class thread-safe seemed unnecessary
Issue Time Tracking
-------------------
Worklog Id: (was: 885221)
Time Spent: 3h 20m (was: 3h 10m)
> Use LRU cache by default
> ------------------------
>
> Key: WW-5355
> URL: https://issues.apache.org/jira/browse/WW-5355
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
