[
https://issues.apache.org/jira/browse/TEZ-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193788#comment-14193788
]
Siddharth Seth commented on TEZ-1547:
-------------------------------------
bq. Because the VM can inform us about desire to reconfigure a vertex further
at that point too. So we cannot automatically send the event until then.
Vertices may start but still be reconfigured after that. So its necessary to
differentiate between them. If future changes allow more kinds of
reconfiguration, then FULLY_CONFIGURED needs to continue to support that.
STARTED does not have any definitive meaning. Hence I am in favor of keeping it
as is.
The VM re-configuring the vertex as part of an onVertexStarted() invocation -
is just that a RECONFIGURATION. If the event were to be sent out via
setParallelism (which is the only re-configuration API today) - notifications
would go out immediately.
bq. STARTED does not have any definitive meaning. Hence I am in favor of
keeping it as is.
I'd disagree with that. onVertexStarted has some meaning to a VM - likewise,
STARTED state has meaning.
Please do not commit the patch till we can come to a conclusion on this.
> Make use of state change notifier in VertexManagerPlugins
> ---------------------------------------------------------
>
> Key: TEZ-1547
> URL: https://issues.apache.org/jira/browse/TEZ-1547
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1547.1.patch, TEZ-1547.3.patch, TEZ-1547.4.patch,
> TEZ-1547.5.patch, TEZ-1547.6.patch, TEZ-1547.7.patch, TEZ-1547.8.patch,
> TEZ-1547.9.patch
>
>
> Instead of the various APIs like onVertexStarted, simple notifications could
> be sent.
> Some existing APIs could end up being deprecated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
