[ 
https://issues.apache.org/jira/browse/TEZ-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194065#comment-14194065
 ] 

Bikas Saha commented on TEZ-1547:
---------------------------------

Sure, STARTED has some meaning. But that is not the meaning implied by this 
event. Hence a different name that means what is implied. OnVertexStarted() is 
called at the point when the vertex is going to move into the RUNNING state. So 
effectively the existing RUNNING state change event is the STARTED event. At 
this point the vertex is free to start tasks if it wants to. So RUNNING is 
equivalent to started. The vertex may still be reconfigured after that. So the 
configured notification should be different from the started notification. 
Secondly, the vertex may not be reconfigured if the VM is not doing anything 
fancy. But interested listeners cannot differentiate that. All they need to 
know is if they can count on the vertex being fully defined. Calling this 
reconfigured would imply that the configuration has changed from what it was 
initially (eg. the PARALLELISM_UPDATED event is sent only if the parallelism 
has indeed changed). I hope this clarifies the nomenclature.

> Make use of state change notifier in VertexManagerPlugins
> ---------------------------------------------------------
>
>                 Key: TEZ-1547
>                 URL: https://issues.apache.org/jira/browse/TEZ-1547
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Bikas Saha
>         Attachments: TEZ-1547.1.patch, TEZ-1547.3.patch, TEZ-1547.4.patch, 
> TEZ-1547.5.patch, TEZ-1547.6.patch, TEZ-1547.7.patch, TEZ-1547.8.patch, 
> TEZ-1547.9.patch
>
>
> Instead of the various APIs like onVertexStarted, simple notifications could 
> be sent.
> Some existing APIs could end up being deprecated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to