abstractdog commented on code in PR #299:
URL: https://github.com/apache/tez/pull/299#discussion_r1250806738
##########
tez-api/src/main/java/org/apache/tez/dag/api/TezConfiguration.java:
##########
@@ -2296,4 +2296,12 @@ static Set<String> getPropertySet() {
@ConfigurationProperty
public static final String TEZ_MRREADER_CONFIG_UPDATE_PROPERTIES =
"tez.mrreader.config.update.properties";
+ /**
+ * Frequency at which thread dump should be captured.
+ */
+ @ConfigurationScope(Scope.DAG)
+ @ConfigurationProperty
+ public static final String TEZ_JOB_PERIODIC_THREAD_DUMP_FREQUENCY =
"tez.job.periodic.thread.dump.frequency";
Review Comment:
can we add the unit to the config name for clarity? also, "job" doesn't hold
any useful information (we simply make thread dumps in every containers), this
can be like:
```
tez.periodic.thread.dump.frequency.ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
