abstractdog commented on code in PR #299:
URL: https://github.com/apache/tez/pull/299#discussion_r1252771462
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -952,6 +960,12 @@ public void shutdown(boolean now) {
}
LOG.info("Handling DAGAppMaster shutdown");
+ // Check if the thread dump service is up in any case, if yes attempt a
shutdown
+ if (tezThreadDumpHelper != null) {
Review Comment:
I don't think we need this here, but if you want to be cautious, you can
still do this into serviceStop
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -952,6 +960,12 @@ public void shutdown(boolean now) {
}
LOG.info("Handling DAGAppMaster shutdown");
+ // Check if the thread dump service is up in any case, if yes attempt a
shutdown
+ if (tezThreadDumpHelper != null) {
Review Comment:
I don't think we need this here, but if you want to be cautious, you can
still do this in serviceStop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
