abstractdog commented on code in PR #299:
URL: https://github.com/apache/tez/pull/299#discussion_r1254024709
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -766,6 +768,8 @@ protected synchronized void handle(DAGAppMasterEvent event)
{
"DAGAppMaster Internal Error occurred");
break;
case DAG_FINISHED:
+
TezThreadDumpHelper.shutdownPeriodicThreadDumpService(tezThreadDumpHelper);
+ tezThreadDumpHelper = null;
Review Comment:
do we need to invalidate this reference?
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -2201,6 +2205,10 @@ public Void run() throws Exception {
execService.shutdownNow();
}
+ // Check if the thread dump service is up in any case, if yes attempt a
shutdown
+ TezThreadDumpHelper.shutdownPeriodicThreadDumpService(tezThreadDumpHelper);
+ tezThreadDumpHelper = null;
Review Comment:
do we need to invalidate this reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
