[
https://issues.apache.org/jira/browse/TEZ-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033523#comment-14033523
]
Bikas Saha commented on TEZ-1206:
---------------------------------
I took a quick look. There are a lot of white space edits in the patch which
are distracting and also add noise to edit history in git. Please remove them
and put them in a separate jira if they are really needed.
Do all existing tests pass? Would be good to also try the new code out in a
secure env to make sure that the refactoring in dag app master did not end up
inadvertently breaking that.
What will happen if amRmClient.stop() throws an exception in the finally block?
Why has that been moved into the finally block?
> Lifecycle issues with DAGAppMaster
> ----------------------------------
>
> Key: TEZ-1206
> URL: https://issues.apache.org/jira/browse/TEZ-1206
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Oleg Zhurakousky
> Assignee: Oleg Zhurakousky
> Attachments: TEZ-1206.patch
>
>
> This is an umbrella issue to document and address issues with DAGAppMaster
> lifecycle
--
This message was sent by Atlassian JIRA
(v6.2#6252)
