[
https://issues.apache.org/jira/browse/TEZ-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071452#comment-14071452
]
Siddharth Seth commented on TEZ-717:
------------------------------------
Looked at FrameworkClient and the implementing classes (Haven't looked at the
LocalClient / TezLocalClient yet since I'm not sure if those are ready or not).
Overall, I think this looks good. Some comments.
- Instead of an explicit requirement to call setSessionAppId after
createApplicationId - is it fair to expect the client implementation to
remember the last appId it created.
- The init method is likely not required. A start should be adequate.
- submitDAG - should this return dagId or a DAGClient. If returning a dagId -
creation of the DagClient should be done by the FrameworkClient implementation.
I believe the local client uses RPC for the DAGClient - is that because there's
no existing non-rpc implementation ?
- In TezClient,
{code}TezClientUtils.createSessionToken(sessionAppId.toString(),
jobTokenSecretManager, credentials);{code}
This token is already generated and is part of the sessionsCredentials. It can
be pulled from there. If the token needs to be added to the current UGI - it
should be done in the LocalMode. However, I don't think that should be required
- since the DAGAppMaster code should take care of handling the token correctly,
and adding it to the appropriate UGI.
- There's separate methods for close(), killApplication and shutdownSession.
Does it make sense to merge some of these - killApplication/shutdownSession.
- Not part of this patch, but the build() at the end of
"requestBuilder.setDAGPlan(dagPlan).build();" is unnecessary.
> Client changes to allow local mode DAG submission
> -------------------------------------------------
>
> Key: TEZ-717
> URL: https://issues.apache.org/jira/browse/TEZ-717
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Chen He
> Attachments: TEZ-717-v6.patch, TEZ-717.patch, TEZ-717.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
