AbdelrahmanElawady opened a new pull request, #7669: URL: https://github.com/apache/trafficcontrol/pull/7669
<!-- Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md If this closes or relates to an existing issue, please reference it using one of the following: Closes: #ISSUE Related: #ISSUE If this PR fixes a security vulnerability, DO NOT submit! Instead, contact the Apache Traffic Control Security Team at secur...@trafficcontrol.apache.org and follow the guidelines at https://apache.org/security regarding vulnerability disclosure. --> Add the least required changes to run Varnish in a topology with parents by reusing some implementation already made in `go-atscfg` and add Dockerfile for Varnish to be testable in CIAB. <!-- **^ Add meaningful description above** --><hr/> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this PR. Feel free to add the name of a tool or script that is affected but not on the list. --> - Traffic Control Cache Config (`t3c`, formerly ORT) - CDN in a Box ## What is the best way to verify this PR? <!-- Please include here ALL the steps necessary to test your PR. If your PR has tests (and most should), provide the steps needed to run the tests. If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. --> Using CIAB: - change the dockerfile path to point to varnish dir in either edge or mid. - change the status to ONLINE in the cache server you choose overriding Traffic Monitor reports. for edge it will be [here](https://github.com/apache/trafficcontrol/blob/master/infrastructure/cdn-in-a-box/traffic_ops/to-access.sh#L217). - start docker-compose and curl the CDN domain from enroller container. - check varnish container logs to verify it properly handled the request. - try again and it should be a hit returning cached object. Note: it has some issues with mid-02 as the initial data from Traffic Ops does not show any parents or origins. So, ATS `remap.config` and `parent.config` is initially empty unlike edge and mid-01. but, since t3c is running periodically it gets fixed once the data is correct. In Varnish case since t3c-apply is not integrated with Varnish only initial data is used and it is not changed. So, it is not working as mid-02 only mid-01. you can avoid that by adding `sleep` before running t3c-generate to ensure right data exists. ## PR submission checklist - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. --> - [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. --> - [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
