AbdelrahmanElawady commented on code in PR #7669:
URL: https://github.com/apache/trafficcontrol/pull/7669#discussion_r1282949540
##########
cache-config/t3c-apply/torequest/torequest.go:
##########
@@ -1188,7 +1192,13 @@ func (r *TrafficOpsReq) StartServices(syncdsUpdate
*UpdateStatus, metaData *t3cu
log.Errorln("ATS configuration has changed. The new
config will be picked up the next time ATS is started.")
} else if serviceNeeds == t3cutil.ServiceNeedsReload {
log.Infoln("ATS configuration has changed, Running
'traffic_ctl config reload' now.")
- if _, _, err :=
util.ExecCommand(config.TSHome+config.TrafficCtl, "config", "reload"); err !=
nil {
+ reloadCommand := config.TSHome + config.TrafficCtl
+ reloadArgs := []string{"config", "reload"}
+ if cfg.CacheType == "varnish" {
+ reloadCommand = "varnishreload"
Review Comment:
It is done that way because Varnish currently is installed under root. So,
`varnishreload` is currently installed in user's `$PATH`. It will be a problem
indeed if Varnish is installed under different directory. Should Varnish be
installed under different directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
