AbdelrahmanElawady commented on code in PR #7669: URL: https://github.com/apache/trafficcontrol/pull/7669#discussion_r1282930571
########## cache-config/t3c-apply/config/config.go: ########## @@ -533,6 +535,9 @@ If any of the related flags are also set, they override the mode's default behav if tsHome != "" { TSHome = tsHome tsConfigDir = tsHome + "/etc/trafficserver" + if cache != nil && *cache == "varnish" { + tsConfigDir = tsHome + "/etc/varnish" Review Comment: I believe the config dir will be either `home + /etc/trafficserver`, `home + /etc/varnish` or if `--trafficserver-home` flag is not used it will default to `/opt/trafficerver/etc/trafficserver` and won't go into the if block (which is not good) other than that it will be `home + /etc/varnish` for varnish case. For example specifying `--trafficserver-home` flag with `/opt/cache` will write the config to `/opt/cache/etc/varnish` and that is what is done in varnish [entrypoint](https://github.com/AbdelrahmanElawady/trafficcontrol/blob/add-parents-varnish/infrastructure/cdn-in-a-box/varnish/run.sh#L85). I think ultimately default home and config dir shouldn't be related to TS. However, this change will affect CIAB, tests, workflows and some other code depending on that. So, Maybe it would be better if it is done in a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org