[ https://issues.apache.org/jira/browse/TS-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601821#comment-14601821 ]
ASF GitHub Bot commented on TS-2150: ------------------------------------ Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/229#discussion_r33297453 --- Diff: proxy/logging/LogField.cc --- @@ -132,6 +168,13 @@ LogField::LogField(const char *name, const char *symbol, Type type, MarshalFunc m_time_field = (strcmp(m_symbol, "cqts") == 0 || strcmp(m_symbol, "cqth") == 0 || strcmp(m_symbol, "cqtq") == 0 || strcmp(m_symbol, "cqtn") == 0 || strcmp(m_symbol, "cqtd") == 0 || strcmp(m_symbol, "cqtt") == 0); + + if (m_milestone_map.empty()) { --- End diff -- This should really be in a local function or method, since it's used multiple times. > Add Milestone log tags > ---------------------- > > Key: TS-2150 > URL: https://issues.apache.org/jira/browse/TS-2150 > Project: Traffic Server > Issue Type: New Feature > Components: Logging > Reporter: Leif Hedstrom > Assignee: John Rushford > Labels: yahoo > Fix For: sometime > > > We have a notion of milestones in the core, and plugin APIs > (TSHttpTxnMilestoneGet() ). It'd be useful to expose these milestone timers > as a log tag, something like: > {code} > %<{UA_BEGIN}mtms> > {code} > mtms is just an example / suggestion, "MilestoneTimeMilliSecond", we can make > it whatever we like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)