[ https://issues.apache.org/jira/browse/TS-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601846#comment-14601846 ]
ASF GitHub Bot commented on TS-2150: ------------------------------------ Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/229#issuecomment-115379759 Looking much better. I think the `std::map` use is acceptable - it's not modified on the critical path and so there are no allocations which should be fine. Searching in `std::map` should be fast, especially for such a small set of strings. The initialization, though, shouldn't be cut and pasted so many places. Maybe that should be done in `Log::init_fields` as it is part of the field initialization. My only other general comment is that sometimes `Milestone::diff` is used and sometimes the value are directly subtracted. That's a minor quibble, though. The real improvement there was from the millisecond computations which look a lot cleaner now. > Add Milestone log tags > ---------------------- > > Key: TS-2150 > URL: https://issues.apache.org/jira/browse/TS-2150 > Project: Traffic Server > Issue Type: New Feature > Components: Logging > Reporter: Leif Hedstrom > Assignee: John Rushford > Labels: yahoo > Fix For: sometime > > > We have a notion of milestones in the core, and plugin APIs > (TSHttpTxnMilestoneGet() ). It'd be useful to expose these milestone timers > as a log tag, something like: > {code} > %<{UA_BEGIN}mtms> > {code} > mtms is just an example / suggestion, "MilestoneTimeMilliSecond", we can make > it whatever we like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)