[ 
https://issues.apache.org/jira/browse/TS-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605982#comment-14605982
 ] 

ASF GitHub Bot commented on TS-2150:
------------------------------------

Github user SolidWallOfCode commented on the pull request:

    https://github.com/apache/trafficserver/pull/229#issuecomment-116773852
  
    I discussed this with Bryan and Susan and we think the least worst option 
is to put two milestone indices in the `LogField` class. The code in 
`LogFormat.cc` that creates the `LogField` instances has no provisions for 
creating sublcasses, which IMHO is a problem but outside the scope of this bug. 
Therefore we recommend adding two milestone indices to `LogField` and storing 
the appropriate milestone indices there in the constructor (by doing the lookup 
in the map)  and then using those (instead of doing the lookup) during actual 
logging operations.


> Add Milestone log tags
> ----------------------
>
>                 Key: TS-2150
>                 URL: https://issues.apache.org/jira/browse/TS-2150
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Logging
>            Reporter: Leif Hedstrom
>            Assignee: John Rushford
>              Labels: yahoo
>             Fix For: sometime
>
>
> We have a notion of milestones in the core, and plugin APIs 
> (TSHttpTxnMilestoneGet() ). It'd be useful to expose these milestone timers 
> as a log tag, something like:
> {code}
> %<{UA_BEGIN}mtms>
> {code}
> mtms is just an example / suggestion, "MilestoneTimeMilliSecond", we can make 
> it whatever we like.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to