zuston commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980680637
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName()
+ " handler", e);
+ throw new RssException("Failed to read shuffle data from " +
getCurrentHandlerName() + " handler", e);
Review Comment:
> It should fast fail on network failure when reading shuffle data from
memory/localfile/hdfs in ComposedClientReadHandler. If not, it will throw
inconsistent blockIds and make users confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
