jerqi commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980690336
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName()
+ " handler", e);
+ throw new RssException("Failed to read shuffle data from " +
getCurrentHandlerName() + " handler", e);
Review Comment:
But if you read data from memory, and this data is writing to the localfile,
the data is incomplete, when we read the incomplete data, it will throw an
exception. The exception prevent us reading the data from HDFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
