jerqi commented on code in PR #213:
URL: https://github.com/apache/incubator-uniffle/pull/213#discussion_r980793720
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/ComposedClientReadHandler.java:
##########
@@ -127,7 +127,7 @@ public ShuffleDataResult readShuffleData() {
return null;
}
} catch (Exception e) {
- LOG.error("Failed to read shuffle data from " + getCurrentHandlerName()
+ " handler", e);
+ throw new RssException("Failed to read shuffle data from " +
getCurrentHandlerName() + " handler", e);
Review Comment:
> I think it wont happen that client reads the incomplete blocks from
server's memory.
>
> I think we should handle all the retriable exceptions and then fail fast
for other exceptions.
Is it possible to read incomplete local file data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
