rickyma commented on code in PR #2538:
URL: https://github.com/apache/uniffle/pull/2538#discussion_r2189208425
##########
common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java:
##########
@@ -368,4 +368,12 @@ public class RssClientConf {
.intType()
.defaultValue(120)
.withDescription("Read prefetch timeout seconds");
+
+ public static final ConfigOption<Boolean>
+ RSS_CLIENT_RPC_POOLED_BYTE_BUF_ALLOCATOR_SMALL_CACHE_ENABLED =
+
ConfigOptions.key("rss.client.rpc.pooledByteBufAllocatorWithSmallCacheEnabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "The option to control whether enable the pooled byte buf
allocator small cache. This is only valid for spark driver side grpc server");
Review Comment:
Also, we need to describe this new config in docs.
##########
common/src/main/java/org/apache/uniffle/common/rpc/GrpcServer.java:
##########
@@ -102,14 +103,17 @@ static void reset() {
}
private Server buildGrpcServer(int serverPort) {
+ boolean isClientSmallCacheEnabled =
Review Comment:
Maybe we can put this config into `RssBaseConf` also? Because all other
configs are in it.
In this way, we should rename it to `isSmallCacheEnabled` thus it could be
used both in clients or servers?
##########
common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java:
##########
@@ -368,4 +368,12 @@ public class RssClientConf {
.intType()
.defaultValue(120)
.withDescription("Read prefetch timeout seconds");
+
+ public static final ConfigOption<Boolean>
+ RSS_CLIENT_RPC_POOLED_BYTE_BUF_ALLOCATOR_SMALL_CACHE_ENABLED =
+
ConfigOptions.key("rss.client.rpc.pooledByteBufAllocatorWithSmallCacheEnabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "The option to control whether enable the pooled byte buf
allocator small cache. This is only valid for spark driver side grpc server");
Review Comment:
Option to control whether to enable the small cache in the pooled byte
buffer allocator. This option is only applicable to the gRPC server on the
Spark driver side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
