rickyma commented on code in PR #2538:
URL: https://github.com/apache/uniffle/pull/2538#discussion_r2189173795
##########
common/src/main/java/org/apache/uniffle/common/rpc/GrpcServer.java:
##########
@@ -102,14 +103,17 @@ static void reset() {
}
private Server buildGrpcServer(int serverPort) {
+ boolean isClientSmallCacheEnabled =
Review Comment:
Maybe we can put this config into `RssBaseConf` also? Because all other
configs are in it.
In this way, we should rename it to `isSmallCacheEnabled` thus it could be
used both in clients and servers?
Then, we need to change the description of it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
