rickyma commented on code in PR #2538: URL: https://github.com/apache/uniffle/pull/2538#discussion_r2191364938
##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -55,6 +55,13 @@ public class RssBaseConf extends RssConf {
.defaultValue(true)
.withDescription("If enable metrics for rpc connection");
+ public static final ConfigOption<Boolean> RPC_NETTY_SMALL_CACHE_ENABLED =
+ ConfigOptions.key("rss.rpc.netty.smallCacheEnabled")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription(
+ "The option to control whether the grpc underlying netty
allocator small cache is enabled.");
Review Comment:
nit:
The option to control whether the small cache of the Netty allocator used by
gRPC is enabled.
##########
docs/server_guide.md:
##########
@@ -75,6 +75,7 @@ This document will introduce how to deploy Uniffle shuffle
servers.
| rss.coordinator.rpc.client.type | GRPC
| The client type for
coordinator rpc client.
|
| rss.rpc.server.type | GRPC_NETTY
| Shuffle server type,
supports GRPC_NETTY, GRPC. The default value is GRPC_NETTY. We recommend using
GRPC_NETTY to enable Netty on the server side for better stability and
performance.
|
| rss.rpc.server.port | 19999
| RPC port for Shuffle
server, if set zero, grpc server start on random port.
|
+| rss.rpc.netty.smallCacheEnabled | true
| The option to control
whether the grpc underlying netty allocator small cache is enabled
|
Review Comment:
The option to control whether the small cache of the Netty allocator used by
gRPC is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
