On 17.08.20 11:06, Alice Guo wrote: >> -----Original Message----- >> From: Jan Kiszka <jan.kis...@siemens.com> >> Sent: 2020年8月14日 21:48 >> To: Alice Guo <alice....@nxp.com>; jailhouse-dev@googlegroups.com >> Cc: Peng Fan <peng....@nxp.com> >> Subject: [EXT] Re: [PATCH V2 4/4] configs: arm64: imx8dxl: add cell >> configuration >> files >> >> Caution: EXT Email >> >> On 15.08.20 21:09, Alice Guo wrote: >>> Add imx8dxl-gic-demo-aarch32.c to support AArch32 VM on the imx8dxl >>> platform. Distinguish whether it is AArch32 inmate cell by the macro >>> JAILHOUSE_CELL_AARCH32. >>> >>> Add "imx8dxl-gic-demo-aarch64.c" for AArch64 VM. >>> >>> "imx8dxl.c" is used for the root cell. >>> >>> Signed-off-by: Alice Guo <alice....@nxp.com> >>> --- >>> configs/arm64/imx8dxl-gic-demo-aarch32.c | 64 +++++++++ >>> configs/arm64/imx8dxl-gic-demo-aarch64.c | 64 +++++++++ >> >> Sorry, missed that so far: >> >> Please add a imx8dxl-inmate-demo.c, instead of aarch64, and make sure it is >> in >> line with other inmate-demo configs. That will ease using this target with >> all >> kinds of inmates, including tests (once we have more...). >> >> And for the aarch32 variant: If the only difference is the flag, maybe put >> that in >> a define and include the imx8dxl-inmate-demo.c, rather than copying it. Will >> make maintenance easier. > > > [alice]: > Accoring your comment, add the following code to > configs/arm64/imx8dxl-gic-demo.c. > But it cannot work correctly because this file will not be compiled when > building for arm32. Do them need to be changed? > #if defined(CONFIG_ARM) > .flags = JAILHOUSE_CELL_PASSIVE_COMMREG | > JAILHOUSE_CELL_AARCH32, #elif defined(CONFIG_ARM64) > .flags = JAILHOUSE_CELL_PASSIVE_COMMREG, #endif >
I was thinking of imx8dxl-inmate-demo.c: #ifdef USE_AARCH32 .flags = JAILHOUSE_CELL_PASSIVE_COMMREG | JAILHOUSE_CELL_AARCH32, #else .flags = JAILHOUSE_CELL_PASSIVE_COMMREG, #endif and imx8dxl-inmate-demo-aarch32.c: #define USE_AARCH32 #include "imx8dxl-inmate-demo.c" Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to jailhouse-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jailhouse-dev/58bbc203-5599-20d6-40ad-f99d555c5d35%40siemens.com.
