Hoi Joep, And of course everybody
I stayed on low profile because you al where very, sorry, VERY busy with jallib and I did not want to disturb you all in your GREAT work. About lcd_st7036.jal (or maybe rename to lcd_dogm), I changed the lib to make it the same as hd44880_4.jal and therefore removed al the extra functions and put those temporarily in addition.jal I agree with you Joep, it is also my idea to add al the nice, useful functions from addition.jal into print.jal, ore format.jal like the time and date procedure and all the function only related to lcd like the clear_line and shift left or right or progress bar put them in all the lcd libraries (if Rob agrees). All the fuction you see in addition.jal are working also on hd44880 lcd,s so not only dogm related. If you want the dogm to be added to jallib, I think all functions and procedure calls on both types should be the same. Also why not add the lcd_init() call in the library in stead of in the main file? If you have the March edition of the Elektor magazine you can see the lcd on page 37 and also on this side: http://www.lcd-module.com/products/dog.html Greetz Richard On 16 feb, 08:48, Joep Suijs <[email protected]> wrote: > Hi Richard, > > Good to hear from you again! > I think it is a good idea to add st7036 to jallib. The reason we did > not before is that it seemed not to be ready. > > Could you explain what the relation between lcd_addition and lcd_st7036 is? > At first glance I see different groups of procedures in lcd_addition: > > - _lcd_write_command - This seems to be a pretty low-level function > that fits better in lcd_st7036. > - procedures like clear_line, home etc. These seem to be dedicated to > lcd_st7036 (and won't work on other displays without a change). If > this is the case, I think it is better to make them part of lcd_st7036 > and maybe someone can extend the other lcd libs also with this > functions. > - procedures like bvalue* and lcd_date. They look like generic > formatting functions, that could be used on any stream. Why do you use > format.jal or print.jal for this? IMHO we should not provide specific > procedures (in this case: print a byte in hex on lcd) while we have a > generic way to do so (and if you need something that could be generic > but is not available, we shoud add it there). But others may have a > different opinion... > > Joep > > 2009/2/15 <[email protected]>: > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
