Hoi Seb, I am now at work so I will change everything back to origin this evening. than if jou know how the libs must look like i will change outside of jallib and place them back when they compile without errors.
Greetz Richard On 17 feb, 23:07, Sebastien Lelong <[email protected]> wrote: > Hi Richard, > > I've seen the buildbot complained about a sample using ldc_st7036.jal lib, > which can't get compiled. This is: > > sample/by_device/16f877/lcd_format_st7036.jal > > It says, about the library itself: > > "_lcd_write_command" not defined > > The sample itself does not compile too, because it's probably not up-to-date > according to your last modifications. Could you fix this, so the build bot > is happy again ? It's important to keep successful build. FYI, buildbot is > supposed to trigger a build for each new commit, and when no change has been > added (no commit) for 3 hours. In other words, as soon as someone commits > something, it waits 3 hours before building. > > For more information, > see:http://groups.google.com/group/jallib/msg/445b29dfa1f6461dand check > attachments (compile.out) > > Cheers, > Seb > > > > > > > > > On 16 feb, 18:54, Joep Suijs <[email protected]> wrote: > > > 2009/2/16 Ritchie <[email protected]>: > > > > > About lcd_st7036.jal (or maybe rename to lcd_dogm) > > > > Would it be a good idea to change it to dogm? > > > The graphic display can also be added in the library although it uses > > an other controller. > > Both are serial and look a like, then dogm would be obvious to name > > the library. > > > > Isn't this lib compatible with other displays with the same controller? > > as far as i can see means same controller, same protocoll and thus > > compatible > > > > And I suspect it is not (yet) suitable with all dogm displays (i saw > > > there are graphical ones also). > > > i think the fuction _lcd_write_command() can be used for sending the > > actual information but making al kinds of nice fuctions like line(), > > circle(), squar(), etc.would be a lot more difficult. > > > > > I changed the lib > > > > to make it the same as hd44880_4.jal > > > > I think this is a good thing - a library that provides similar > > > functionality should have the same interface. > > > OK but this could mean we have to add the same procedures we are going > > to add to lcd_st7036, related to non graphic (if combined), to Rob,s > > hd44880_4.jal and hd44880_8.jal. > > > > > and therefore removed al the extra functions and put those temporarily > > in addition.jal > > > > > I agree with you Joep, it is also my idea to add al the nice, useful > > > > functions from addition.jal into print.jal, ore format.jal like the > > > > time and date procedure and all the function only related to lcd like > > > > the clear_line and shift left or right or progress bar put them in all > > > > the lcd libraries (if Rob agrees). > > > > Maybe we should have an lcd_common library that has functions that run > > > on all (most) lcd's. > > > This is off course possible but than you have to add 2 libs in your > > main file instead of just one. > > It also does not make it easier to use and it does not save memory of > > the controller and hardly any of the harddisk so why make a special > > function lib?. > > > I only split lcd_st7036.jal because I thought you all want this, but I > > don't see the benefit of it. > > > > If you look at the functions that are in addition, could you split > > > them in three groups: > > > - ones that are specific for this display (like lcd_home, > > > lcd_shift_right - i suspect they are different on other displays, > > > not?) > > > no, same on hd44880 > > > > - the ones that are generic stream candidates (i think lcd_date, > > > lcd_string; the lcd_b* and lcd_w* do provide a bit extra over the > > > print/format candidates - would that be worth to add them as separate > > > functions?) > > > lcd_string is same as in print.jal, I added because off only needing > > one lib for lcd. > > lcd_date is very flexible it would be nice to keep him this way no > > matter where he ends. > > lcd_b* and lcd_w* are non leading zero optional left alligned, signed > > or unsigned, with or without decimal point line and row. > > if we remove line and row, it would be a nice procedure to add to > > print (although left alignment is not useful for serial transmission) > > > > - The ones that work on any display (lcd_progress?) > > t least on st7036 adn hd44880 > > > > > All the fuction you see in addition.jal are working also on hd44880 > > > > lcd,s so not only dogm related. > > > > Do you mean that the same fuction works on the 44880 or that the 44880 > > > I mean i wrote to libraries with the same procedure calls, one for > > st7036 and one for hd44880, so yes the same function works on hd44880 > > with the sam fuction call. > > > > support the same feature, so there should be a function too? > > > > > If you want the dogm to be added to jallib, I think all functions and > > > > procedure calls on both types should be the same. > > > > Definitely. > > > as i said before, this means we have to modify hd44880. > > > > > Also why not add the lcd_init() call in the library in stead of in the > > > > main file? > > > > This is a matter of taste and iirc we debated about this. The way it > > > is now, including a lib on itself does not generate any code. > > > OK clear, i will remove him from the lib and added in the comments > > > > > If you have the March edition of the Elektor magazine you can see the > > > > lcd on page 37 and also on this side: > > > >http://www.lcd-module.com/products/dog.html > > > > I just build a board with a graphical display (128*64) to create a > > > lib. I wish I had not so I needed to buy such a neat display... > > > Not only need but very cheap > > > Please let me know which procedures in lcd_addition.jal you all want > > in which library so I or somebody else can add them. > > > greetz > > > Richard > > -- > Sébastien Lelonghttp://www.sirloon.nethttp://sirbot.org- Tekst uit > oorspronkelijk bericht niet weergeven - > > - Tekst uit oorspronkelijk bericht weergeven - --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
