2009/2/16 Ritchie <[email protected]>: > > About lcd_st7036.jal (or maybe rename to lcd_dogm) Would it be a good idea to change it to dogm? Isn't this lib compatible with other displays with the same controller? And I suspect it is not (yet) suitable with all dogm displays (i saw there are graphical ones also).
> I changed the lib > to make it the same as hd44880_4.jal I think this is a good thing - a library that provides similar functionality should have the same interface. > and therefore removed al the extra functions and put those temporarily in > addition.jal > > I agree with you Joep, it is also my idea to add al the nice, useful > functions from addition.jal into print.jal, ore format.jal like the > time and date procedure and all the function only related to lcd like > the clear_line and shift left or right or progress bar put them in all > the lcd libraries (if Rob agrees). Maybe we should have an lcd_common library that has functions that run on all (most) lcd's. If you look at the functions that are in addition, could you split them in three groups: - ones that are specific for this display (like lcd_home, lcd_shift_right - i suspect they are different on other displays, not?) - the ones that are generic stream candidates (i think lcd_date, lcd_string; the lcd_b* and lcd_w* do provide a bit extra over the print/format candidates - would that be worth to add them as separate functions?) - The ones that work on any display (lcd_progress?) > All the fuction you see in addition.jal are working also on hd44880 > lcd,s so not only dogm related. Do you mean that the same fuction works on the 44880 or that the 44880 support the same feature, so there should be a function too? > If you want the dogm to be added to jallib, I think all functions and > procedure calls on both types should be the same. Definitely. > Also why not add the lcd_init() call in the library in stead of in the > main file? This is a matter of taste and iirc we debated about this. The way it is now, including a lib on itself does not generate any code. > If you have the March edition of the Elektor magazine you can see the > lcd on page 37 and also on this side: > http://www.lcd-module.com/products/dog.html I just build a board with a graphical display (128*64) to create a lib. I wish I had not so I needed to buy such a neat display... Joep --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
