Hi guys,

I have my doubts about the quality of some sample programs. For example in 18f4550_usb_hid_generic.jal I read:

-- adc lib is horribly broken, it won't work K50 series, so disable for the 
time being

I think when a sample contains comments like this it should not be released (but it is in the current 06beta2).

Apart from that, what is the purpose of the following code (just below the above comment)?

if (  (target_chip == PIC_18F14K50 ) |
      (target_chip == PIC_18F13K50 ) |
      (target_chip == PIC_18LF14K50 ) |
      (target_chip == PIC_18LF13K50 ) )then
   const bit no_analog = true
else
   const bit no_analog = true
end if

The effect of the 'if' and 'else' branch are idential. So the if-then-else is only ballast. The educational value of code like this is negative!

I didn't scan all samples ...

Regards, Rob.

--
R. Hamerling, Netherlands --- http://www.robh.nl

--
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en.

Reply via email to