Hi Burt, all samples should work. What samples are not working? Rob, you are right about the comment about ADC. It is not good to discourage someone from using ADC. Instead, the problem with ADC should have been brought to our attention. If the code writer does not like a lib, he can just say ADC lib will not work for this purpose.
As for the code, there's nothing you can do about mistakes. It would be nice if someone could review the writers code before a sample gets added to torelease, but who is going to do that? Matt. On Sep 2, 8:44 am, Burt Ratliff <[email protected]> wrote: > Your right this could be good jalv2 is great but some of the samples don't > work which is bad because newbe's like me are what make people want to > support jallib and jalv2 I been > using swordfish basic for 2 years found this looking to get in to some usb > coding . > I hope you keep it going I like jalv2 it's good work. > > On Thu, Sep 2, 2010 at 1:58 AM, Rob Hamerling <[email protected]>wrote: > > > > > Hi guys, > > > I have my doubts about the quality of some sample programs. For example in > > 18f4550_usb_hid_generic.jal I read: > > > -- adc lib is horribly broken, it won't work K50 series, so disable for > >> the time being > > > I think when a sample contains comments like this it should not be released > > (but it is in the current 06beta2). > > > Apart from that, what is the purpose of the following code (just below the > > above comment)? > > > if ( (target_chip == PIC_18F14K50 ) | > >> (target_chip == PIC_18F13K50 ) | > >> (target_chip == PIC_18LF14K50 ) | > >> (target_chip == PIC_18LF13K50 ) )then > >> const bit no_analog = true > >> else > >> const bit no_analog = true > >> end if > > > The effect of the 'if' and 'else' branch are idential. So the if-then-else > > is only ballast. The educational value of code like this is negative! > > > I didn't scan all samples ... > > > Regards, Rob. > > > -- > > R. Hamerling, Netherlands ---http://www.robh.nl > > > -- > > You received this message because you are subscribed to the Google Groups > > "jallib" group. > > To post to this group, send email to [email protected]. > > To unsubscribe from this group, send email to > > [email protected]<jallib%[email protected]> > > . > > For more options, visit this group at > >http://groups.google.com/group/jallib?hl=en. -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
