I reviewed the GLCD common library, and I propose some changes. This would affect libraries and samples for ks0108 and nokia3310.
Currently, GLCD common library is only setup for 2 color displays. I believe it can be setup to work with 2 color and 65535 color displays with constants, otherwise will will have duplicate procedures. Please let me know what you think. 1. All procedures should have a color bit lcd_line(), lcd_box(), lcd_clearscreen() - all should contain "byte in color". Currently, the library assumes the user has a "unset" background. How do you know weather the user wants a "set" or "unset" (black or white) background? 2. text also needs color bits, for both background and text color. Text is in another lib. 3. a constant should be added for number of colors: example: -- in sample: const byte GLCD_COLORS = 2 -- LCD has two colors (2 colors could be default in lib) -- in library: if GLCD_COLORS = 2 then var byte GLCD_COLOR_SIZE = 1 elseif GLCD_COLORS = 65535 then var byte GLCD_COLOR_SIZE = 2 else -- give an error endif procedure lcd_clearscreen(byte*GLCD_COLOR_SIZE in color) is lcd_fill(color) -- Clear the display with color (proc in GLCD lib) glcd_char_x_pos = 0; glcd_char_y_pos = 0; end procedure Matt. -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
