Hi Matt,

2010/12/7 mattschinkel <[email protected]>

> I reviewed the GLCD common library, and I propose some changes. This
> would affect libraries and samples for ks0108 and nokia3310.
>

As usual, careful with changing existing API.


>
> Currently, GLCD common library is only setup for 2 color displays. I
> believe it can be setup to work with 2 color and 65535 color displays
> with constants, otherwise will will have duplicate procedures. Please
> let me know what you think.
>
> 1. All procedures should have a color bit
>
> lcd_line(), lcd_box(), lcd_clearscreen() - all should contain "byte in
> color". Currently, the library assumes the user has a "unset"
> background. How do you know weather the user wants a "set" or
> "unset" (black or white) background?
>

So, this would assume using 3310 we need to always give the same and same
color ? I mean, usually, you keep writing in the invert background color. So
in background is white, you write in black, but actually you just write. I
hope you know what I mean.

Maybe you can see writing colors as selecting a pen, instead of constantly
configuring your pen.

var byte*GCD_COLOR_SIZE current_color = GCD_BLUE
lcd_line(...) -- in blue
lcd_box(...) -- still in blue

current_color = 0xFA_FA_FA  -- assuming RGB ?
lcd_line(...)
...

On 3310 for instance:

current_color = GCD_WHITE
lcd_clearscreen() -- all painted white, this is the default if no
current_color is defined
current_color = GCD_BLACK
lcd_...()  -- in black

or

current_color = GCD_BLACK
lcd_clearscreen()
current_color = GCD_WHITE
lcd_...() -- invert

Maybe constant colors could have better names/prefix...


My .2


Cheers
Seb

-- 
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en.

Reply via email to