Hi guys,
I've been looking through the print and print_scalable libraries and
have some comments, suggestions, questions:
1. About 'const _print_max_var_size_dec' in the print_scalable library:
When user may declare this, it should not have a name starting with an
underscore.
Can we drop the '_dec' of this name? Decimal is the compiler default for
numbers, so why the emphasis on 'dec' making the name longer than needed?
2. print_bit_10() is not an intuitive name and not consistent with the
other names: print_bit_binary() seems better to me.
I also would like to suggest to rename print_bit_truefalse() to
print_bit_logic(), and print_bit_highlow() to print_bit_level().
BTW: the suffix '_binary' is not consistent with '_hex' and '_dec', so
it better be renamed to '_bin'.
3. The purpose of const print_prefix is nowhere explained.
4. Not a single procedure is documented.
5. I'm prepared to add headers to the procedures for the JalAPI
documentation, and improve other comments, unless someone else insists
on doing this. :-()
6. After these fixes the print_scalable library seems ready to replace
the print library, who decides and when?
7. I see in the doc/html directory a file print_ng.html, but cannot find
a print_ng library. What happened??
Regards, Rob
--
R. Hamerling, Netherlands --- http://www.robh.nl
--
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en.
