Hi Matt, I've seen you've made different, contradicting naming suggestions.
Specific about this 24lc* functionality: I guess when there is a lib called '24lc256', people tend to use this and not notice one called '24lc256_enhanced'. I'd rather have the difference in both names, e.g. like _compact vs _fast (of _enhanced). > As you can see, all the current samples and libs contain the word > "eeprom" in them. It may be good to keep naming them this way. The > naming you have chosen is quite close to the naming of the device > files. There is no 24lc* lib or sample with 'eeprom' in the name. Your libs have ee_ in the name, which is probably only informative once you know it means eeprom. The samples lack ee_ in the name, so there is no direct link. And you used the name space that would be logic for my (current) lib name. I'm not sure in what way such a description in the name is useful. The function of a particular chip is easy to find with google if required, and it is also described in the lib itself. A user will be looking for a library supporting his particular chip and not 'an eeprom', regardless of the type, size, interface etc? Note that the naming mismatch between the sample and lib is true for quite a few samples and we might consider to change this: a sample is mandatory for each lib and unless there is a good reason, the name of the sample should be the same as the lib. 2012/4/30 mattschinkel <[email protected]>: > Hey Joep, I'm not sure if you saw my other message. > > Can you please rename the files to eeprom_24lc256 so everyone knows > it's an eeprom? > > For example, > > lib name: > 24lc256_extended.jal > > sample: > 18f4550_24lc256_extended.jal > > As you can see, all the current samples and libs contain the word > "eeprom" in them. It may be good to keep naming them this way. The > naming you have chosen is quite close to the naming of the device > files. > > There are other libs with names that don't tell me what it is, for > example mcp9800.jal. I won't know what it is till I open the file. > Most other file names are clear. > > Matt. > > On Apr 22, 2:10 pm, Joep Suijs <[email protected]> wrote: >> These samples were once generated by jallib.py, but are not any >> longer. This means they are not updated when the board files or test >> files are updated. >> >> It is okay to keep those if you trust they are okay. >> From now on, I intend to remove all samples with the text >> 'generated.by.jallib.py' before placing the newly generated samples. >> This way *generated* samples remain up to date. >> >> Joep >> >> 2012/4/22 Rob Hamerling <[email protected]>: >> >> >> >> >> >> >> >> >> >> > Hi Joep, >> >> > On 04/22/12 07:47 pm, Joep Suijs wrote: >> >> >> I found two samples that are not regenerated today: >> >> 16f88_ir_ranger_gp2d02.jal >> >> 16f88_pwm_led.jal >> >> >> I'll remove them unless anybody objects. >> >> > What is the definition of an 'outdated sample'? >> >> > - There is an 'ir_ranger_gp2d02' library and you want >> > to remove the only sample for this library? >> > - What's wrong with the 16f88_pwm_led sample? >> >> > Regards, Rob. >> >> > -- >> > R. Hamerling, Netherlands ---http://www.robh.nl >> >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "jallib" group. >> > To post to this group, send email to [email protected]. >> > To unsubscribe from this group, send email to >> > [email protected]. >> > For more options, visit this group at >> >http://groups.google.com/group/jallib?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
