Chris Hostetter wrote:
: It's a temporary name, no? In the end we probably want to keep the
: _name_ IndexWriter, so why not just it IndexWriter2 and when we are
: happy with it, we make it be the new IndexWriter and we deprecate IW2.
Um... actually that's a really good point, this is first and formost an
extension of IndexWriter ... is there any reason not to rename
"NewIndexModifier" as "IndexWriter" (refactoring the existing IndexWriter
code into it, or moving the renaming the current IndexWriter to
"OldIndexWriter", or "NonDeletingIndexWriter")
the only reason i can think of not to do this would be if we are worried
about people who currently subclass IndexWriter getting a change in
behavior if we change the INdexWRiter out from under them ... is this a
signifcant concern? NewIndexModifier doesn't seem to change any of hte
semantics of the IndexWriter methods it extends.
+1
I think the new methods in NewIndexModifier are low-risk to the
existing IndexWriter, so, we should just add them into IndexWriter and
not create a new class? Then we don't have a naming problem anymore :)
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
