[
https://issues.apache.org/jira/browse/LUCENE-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535350
]
Michael Busch commented on LUCENE-743:
--------------------------------------
{quote}
I think that's a fine direction. Note however that IndexWriter implements
delete by calling IndexReader.delete(). That method could be made
package-private, so that users cannot call it, but then this makes it
impossible for someone to subclass IndexReader from a different package. So
perhaps delete() needs to move to a subclass of IndexReader? That gets messy...
{quote}
Actually all of the lock/commit logic moved from IndexReader to
DirectoryIndexReader already, and the delete logic is in SegmentReader, which
subclasses DirectoryIndexReader. So we could remove the deleteDocument() API
from IndexReader but leave it in DirectoryIndexReader. Then it would still be
possible to extend IndexReader from a different package just as today, and
IndexWriter could use DirectoryIndexReader for performing deletes. These
changes should be trivial.
> IndexReader.reopen()
> --------------------
>
> Key: LUCENE-743
> URL: https://issues.apache.org/jira/browse/LUCENE-743
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Otis Gospodnetic
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.3
>
> Attachments: IndexReaderUtils.java, lucene-743-take2.patch,
> lucene-743.patch, lucene-743.patch, lucene-743.patch, MyMultiReader.java,
> MySegmentReader.java, varient-no-isCloneSupported.BROKEN.patch
>
>
> This is Robert Engels' implementation of IndexReader.reopen() functionality,
> as a set of 3 new classes (this was easier for him to implement, but should
> probably be folded into the core, if this looks good).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
