[ 
https://issues.apache.org/jira/browse/LUCENE-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536028
 ] 

Michael Busch commented on LUCENE-743:
--------------------------------------

Hmm one other thing: how should IndexReader.close() work? If we re-open a 
reader (a is the old reader, b is the new one), and then someone calls 
a.close(), then a should not close any resources that it shares with b. 

One way to make this work would be reference counting. Since we want to avoid 
that, we could simply restrict reopen() from being called twice for the same 
reader. Then there would never be more than 2 readers sharing the same 
ressources. The old reader a would remember that reopen() was called already 
and would not close the shared ressources on close(). However, the new reader b 
would close all ressources, meaning that reader a would not work anymore after 
b.close() was called. 
Thoughts?

> IndexReader.reopen()
> --------------------
>
>                 Key: LUCENE-743
>                 URL: https://issues.apache.org/jira/browse/LUCENE-743
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Otis Gospodnetic
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: IndexReaderUtils.java, lucene-743-take2.patch, 
> lucene-743.patch, lucene-743.patch, lucene-743.patch, MyMultiReader.java, 
> MySegmentReader.java, varient-no-isCloneSupported.BROKEN.patch
>
>
> This is Robert Engels' implementation of IndexReader.reopen() functionality, 
> as a set of 3 new classes (this was easier for him to implement, but should 
> probably be folded into the core, if this looks good).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to