[
https://issues.apache.org/jira/browse/LUCENE-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600169#action_12600169
]
John Patterson commented on LUCENE-1026:
----------------------------------------
Just checked out the source from the svn link above. I've got a few questions
about the code
1 - why use ReentrantLock rather than synchronized blocks? The advice I have
come across is to use the standard mechanism unless you need the extra
functionality. Can't see anywhere in the code that needs this e.g. obtaining
and releasing the lock in different methods or using more than one condition.
2 - why call logger.isLoggable all the time for simple log statements?
3 - In getWriter(boolean) the parameter is ignored if a write already exists.
4 - Why is condition.signalAll() called from getReadingReader()?
> Provide a simple way to concurrently access a Lucene index from multiple
> threads
> --------------------------------------------------------------------------------
>
> Key: LUCENE-1026
> URL: https://issues.apache.org/jira/browse/LUCENE-1026
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Index, Search
> Reporter: Mark Miller
> Priority: Minor
> Attachments: DefaultIndexAccessor.java,
> DefaultMultiIndexAccessor.java, IndexAccessor-02.04.2008.zip,
> IndexAccessor-02.07.2008.zip, IndexAccessor-02.28.2008.zip,
> IndexAccessor-1.26.2008.zip, IndexAccessor-2.15.2008.zip,
> IndexAccessor.04032008.zip, IndexAccessor.java, IndexAccessor.zip,
> IndexAccessorFactory.java, MultiIndexAccessor.java, shai-IndexAccessor-2.zip,
> shai-IndexAccessor.zip, shai-IndexAccessor3.zip, SimpleSearchServer.java,
> StopWatch.java, TestIndexAccessor.java
>
>
> For building interactive indexes accessed through a network/internet
> (multiple threads).
> This builds upon the LuceneIndexAccessor patch. That patch was not very
> newbie friendly and did not properly handle MultiSearchers (or at the least
> made it easy to get into trouble).
> This patch simplifies things and provides out of the box support for sharing
> the IndexAccessors across threads. There is also a simple test class and
> example SearchServer to get you started.
> Future revisions will be zipped.
> Works pretty solid as is, but could use the ability to warm new Searchers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
