I think it's best to implement Externalizable as long as someone is willing to maintain it. I commit to maintaining the Externalizable code. The programming overhead is no more than implementing the equals method in the classes. New classes outside the Lucene code base simply need to implement Serializable to work. External developers are not required to implement Externalizable but may if they see fit.
This will insure forward compatability between serialized versions, make the serialized objects smaller, and make serialization faster. Apparently it matters enough for Hadoop to implement Writeable in all over the wire classes. On Fri, Dec 5, 2008 at 1:47 PM, Michael McCandless < [EMAIL PROTECTED]> wrote: > > OK works for me too. > > John or Jason, can you update the patch on LUCENE-1743? We no longer need > to implement Externalizable (just add fixed SUIDs), but we do need to update > the javadocs for all classes implementing Serializable to state that > cross-version compatibility is not guaranteed. > > Mike > > > John Wang wrote: > > Works for me. >> >> Thanks >> >> -John >> >> On Fri, Dec 5, 2008 at 1:23 PM, Doug Cutting <[EMAIL PROTECTED]> wrote: >> John Wang wrote: >> This has been gone back and forth on this thread already. Again, I >> agree it is not the perfect solution. I am comparing that to the current >> behavior, I don't think it is worse. (Only in my opinion). >> >> So, if it's good enough for you, a user of java serialization, then >> perhaps those of us who don't use java serialization shouldn't complain. I >> think we'd want to add to the documentation something to the effect that >> this is all that's been done, and that if the classes change substantially >> then all bets are off. We do not want to imply that we're making any >> cross-version compatibility guarantees about serialization, rather just that >> folks who're willing to take their chances will not be impeded. Could >> something like that work? >> >> Doug >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
