[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655829#action_12655829
]
Michael McCandless commented on LUCENE-1483:
--------------------------------------------
{quote}
> I'm not a fan of control with exceptions. I am also not a fan of of
> isSupported methods though...I was leaning that way over exceptions...sounds
> like you lean the other way...? I guess it has its appeal in this case...
{quote}
I agree, though I leaned towards using an exception because 1) no new
API needing future deprecation would then have been added, and 2) the
expectation (but not forced, and this is a problem) is that over time
all HitCollector subclasses would implement setBase, so the exception
would be the exception (heh) not the rule.
But I like Doug's proposal instead, since on upgrading to 2.9 you'll
see your code is deprecated, which then allows us to drop it in 3.0.
I have a slight preference for DocCollector.
This means any methods that accept a HitCollector would also be
deprecated, and we'd add a new method that takes DocCollector instead,
and change the deprecated one to wrap a DocBaseCollector around the
HitCollector and invoke the new method.
{quote}
> we can deprecate all public HitCollector implementations and provide new
> versions that extend Hitable
{quote}
Could we leave (eg) TopDocCollector extending HitCollector in 2.9, and
then in 3.0 change it to directly extend DocCollector (Hitable)?
(This saves having to deprecate TopDocCollector and at least 2
others).
{quote}
> Don't we have a lot of latitude with 3.0?
{quote}
I think in 3.0, when changing APIs, we are only allowed to remove
deprecated APIs from 2.9? Ie we can't do more drastic changes.
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
