[
https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715110#action_12715110
]
Uwe Schindler commented on LUCENE-1658:
---------------------------------------
bq. Maybe don't make MMapDir.cleanUnmapping final, so subclasses could tweak
it? I'm still nervous about throwing IOException from that method if the unmap
fails, but if we make it non-final then we can leave the IOException as is and
users can subclass it if need be.
I reactivated this exception (it was disabled before). In my opinion, we should
enable it to notify the user on any problems (e.g. that he may must raise
security privileges to enable it correctly). If the user hits an IOException,
he can switch off the tweak easily. By the way, switching on the tweak throws
IAE if the platform does not support it.
cleanUnmapping is currently not really overrideable, because package-private. I
can unfinal it and make protected, if needed (I wanted to hide this dangerous
method from other usages, not that anyboy calls it for own ByteBuffers and
crashes his JVM).
I will do the other changes, no problem.
> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>
> Key: LUCENE-1658
> URL: https://issues.apache.org/jira/browse/LUCENE-1658
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1658-take2.patch, LUCENE-1658-take2.patch,
> LUCENE-1658-take3.patch, LUCENE-1658-take3.patch, LUCENE-1658-take3.patch,
> LUCENE-1658-take3.patch, LUCENE-1658-take3.patch, LUCENE-1658-take3.patch,
> LUCENE-1658.patch, LUCENE-1658.patch, LUCENE-1658.patch
>
>
> I think whether one uses java.io.* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory. It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
