Well, the patch is in shape to submit, but looking at the various comments on the 3.0 release, I guess I should wait until 3.0 is actually out the door before submitting unless someone just can't wait.
How do we include a new jar file in a patch? Best Erick On Fri, Nov 13, 2009 at 6:25 PM, Erick Erickson <erickerick...@gmail.com>wrote: > OK thanks for adding me to the ACL. I'll have it tomorrow sometime. Does > anyone object to deprecating LuceneTestCase with notations to use > LuceneTestCaseJ4? > > I tried two approaches, both work. Both allow you to use LuceneTestCaseJ4 > rather than LuceneTestCase as a superclass, with the caveat you have to use > the proper annotations with the J4 variant. > > The difference is that for one approach, I copied LuceneTestCase to > LuceneTestCaseJ4 and hacked. The other approach was extracting the meat of > LuceneTestCase to a common class, and using that class as a member of both > variants, delegating to avoid code duplication. > > Personally, I think it'll be cleanest to just clone LuceneTestCase and NOT > extract to common. Eventually LuceneTestCase will fade away, enhancements > should be made to the J4 variant as needed. But if folks have strong > opinions, let me know. > > Best > Erick > > > On Fri, Nov 13, 2009 at 5:02 PM, Chris Hostetter <hossman_luc...@fucit.org > > wrote: > >> : putting too many irons in the fire, especially non-critical ones. I >> don't >> : see a way to assign it to myself, either I'm missing something or I'm >> just >> : underprivileged <G>, so if someone would go ahead and assign it to me >> I'll >> : work on it post 3.0. >> >> Jira's ACLs prevent issues from being assigned to people who aren't listed >> in the "Contributors" group. THe policy has been to add people to that >> list (for issue assignment) on request, so i hooked you up. >> >> (NOTE: if anyone else has issues they're actively working on and would >> like to be flagged as a "Contributor" in Jira so that the issues can be >> assigned directly to you for tracking purpose, please speak up) >> >> >> >> -Hoss >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: java-dev-h...@lucene.apache.org >> >> >
